Blame SOURCES/7.4.421

d6ba96
To: vim_dev@googlegroups.com
d6ba96
Subject: Patch 7.4.421
d6ba96
Fcc: outbox
d6ba96
From: Bram Moolenaar <Bram@moolenaar.net>
d6ba96
Mime-Version: 1.0
d6ba96
Content-Type: text/plain; charset=UTF-8
d6ba96
Content-Transfer-Encoding: 8bit
d6ba96
------------
d6ba96
d6ba96
Patch 7.4.421
d6ba96
Problem:    Crash when searching for "\ze*". (Urtica Dioica)
d6ba96
Solution:   Disallow a multi after \ze and \zs.
d6ba96
Files:	    src/regexp_nfa.c, src/testdir/test64.in, src/testdir/test64.ok
d6ba96
d6ba96
d6ba96
*** ../vim-7.4.420/src/regexp_nfa.c	2014-05-13 19:37:19.489786520 +0200
d6ba96
--- src/regexp_nfa.c	2014-08-29 11:14:12.030416520 +0200
d6ba96
***************
d6ba96
*** 291,296 ****
d6ba96
--- 291,297 ----
d6ba96
  static int nfa_regconcat __ARGS((void));
d6ba96
  static int nfa_regbranch __ARGS((void));
d6ba96
  static int nfa_reg __ARGS((int paren));
d6ba96
+ static int re_mult_next __ARGS((char *what));
d6ba96
  #ifdef DEBUG
d6ba96
  static void nfa_set_code __ARGS((int c));
d6ba96
  static void nfa_postfix_dump __ARGS((char_u *expr, int retval));
d6ba96
***************
d6ba96
*** 1323,1332 ****
d6ba96
--- 1324,1337 ----
d6ba96
  	    {
d6ba96
  		case 's':
d6ba96
  		    EMIT(NFA_ZSTART);
d6ba96
+ 		    if (re_mult_next("\\zs") == FAIL)
d6ba96
+ 			return FAIL;
d6ba96
  		    break;
d6ba96
  		case 'e':
d6ba96
  		    EMIT(NFA_ZEND);
d6ba96
  		    nfa_has_zend = TRUE;
d6ba96
+ 		    if (re_mult_next("\\ze") == FAIL)
d6ba96
+ 			return FAIL;
d6ba96
  		    break;
d6ba96
  #ifdef FEAT_SYN_HL
d6ba96
  		case '1':
d6ba96
***************
d6ba96
*** 2276,2281 ****
d6ba96
--- 2281,2298 ----
d6ba96
      return OK;
d6ba96
  }
d6ba96
  
d6ba96
+ /*
d6ba96
+  * Used in a place where no * or \+ can follow.
d6ba96
+  */
d6ba96
+     static int
d6ba96
+ re_mult_next(what)
d6ba96
+     char *what;
d6ba96
+ {
d6ba96
+     if (re_multi_type(peekchr()) == MULTI_MULT)
d6ba96
+ 	EMSG2_RET_FAIL(_("E888: (NFA regexp) cannot repeat %s"), what);
d6ba96
+     return OK;
d6ba96
+ }
d6ba96
+ 
d6ba96
  #ifdef DEBUG
d6ba96
  static char_u code[50];
d6ba96
  
d6ba96
*** ../vim-7.4.420/src/testdir/test64.in	2014-05-13 16:44:25.633695709 +0200
d6ba96
--- src/testdir/test64.in	2014-08-29 11:33:12.330419011 +0200
d6ba96
***************
d6ba96
*** 459,465 ****
d6ba96
  :  let text = t[2]
d6ba96
  :  let matchidx = 3
d6ba96
  :  for engine in [0, 1, 2]
d6ba96
! :    if engine == 2 && re == 0 || engine == 1 && re ==1
d6ba96
  :      continue
d6ba96
  :    endif
d6ba96
  :    let &regexpengine = engine
d6ba96
--- 459,465 ----
d6ba96
  :  let text = t[2]
d6ba96
  :  let matchidx = 3
d6ba96
  :  for engine in [0, 1, 2]
d6ba96
! :    if engine == 2 && re == 0 || engine == 1 && re == 1
d6ba96
  :      continue
d6ba96
  :    endif
d6ba96
  :    let &regexpengine = engine
d6ba96
***************
d6ba96
*** 608,613 ****
d6ba96
--- 608,624 ----
d6ba96
  "ayb20gg/..\%$
d6ba96
  "bybGo?"apo?"bp:"
d6ba96
  :"
d6ba96
+ :" Check for detecting error
d6ba96
+ :set regexpengine=2
d6ba96
+ :for pat in [' \ze*', ' \zs*']
d6ba96
+ :  try
d6ba96
+ :    let l = matchlist('x x', pat)
d6ba96
+ :    $put ='E888 NOT detected for ' . pat
d6ba96
+ :  catch
d6ba96
+ :    $put ='E888 detected for ' . pat
d6ba96
+ :  endtry
d6ba96
+ :endfor
d6ba96
+ :"
d6ba96
  :""""" Write the results """""""""""""
d6ba96
  :/\%#=1^Results/,$wq! test.out
d6ba96
  ENDTEST
d6ba96
*** ../vim-7.4.420/src/testdir/test64.ok	2014-05-13 16:44:25.633695709 +0200
d6ba96
--- src/testdir/test64.ok	2014-08-29 11:36:05.782419390 +0200
d6ba96
***************
d6ba96
*** 1097,1099 ****
d6ba96
--- 1097,1101 ----
d6ba96
  Test END
d6ba96
  EN
d6ba96
  E
d6ba96
+ E888 detected for  \ze*
d6ba96
+ E888 detected for  \zs*
d6ba96
*** ../vim-7.4.420/src/version.c	2014-08-29 10:04:32.226407390 +0200
d6ba96
--- src/version.c	2014-08-29 11:37:15.794419543 +0200
d6ba96
***************
d6ba96
*** 743,744 ****
d6ba96
--- 743,746 ----
d6ba96
  {   /* Add new patch number below this line */
d6ba96
+ /**/
d6ba96
+     421,
d6ba96
  /**/
d6ba96
d6ba96
-- 
d6ba96
From "know your smileys":
d6ba96
 :----}  You lie like Pinocchio
d6ba96
d6ba96
 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
d6ba96
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
d6ba96
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
d6ba96
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///