Blame SOURCES/7.4.229

d6ba96
To: vim_dev@googlegroups.com
d6ba96
Subject: Patch 7.4.229
d6ba96
Fcc: outbox
d6ba96
From: Bram Moolenaar <Bram@moolenaar.net>
d6ba96
Mime-Version: 1.0
d6ba96
Content-Type: text/plain; charset=UTF-8
d6ba96
Content-Transfer-Encoding: 8bit
d6ba96
------------
d6ba96
d6ba96
Patch 7.4.229
d6ba96
Problem:    Using ":let" for listing variables and the second one is a curly
d6ba96
	    braces expression may fail.
d6ba96
Solution:   Check for an "=" in a better way. (ZyX)
d6ba96
Files:	    src/eval.c, src/testdir/test104.in, src/testdir/test104.ok
d6ba96
d6ba96
d6ba96
*** ../vim-7.4.228/src/eval.c	2014-03-25 18:23:27.062087691 +0100
d6ba96
--- src/eval.c	2014-03-30 16:46:24.464562806 +0200
d6ba96
***************
d6ba96
*** 1856,1863 ****
d6ba96
  	return;
d6ba96
      if (argend > arg && argend[-1] == '.')  /* for var.='str' */
d6ba96
  	--argend;
d6ba96
!     expr = vim_strchr(argend, '=');
d6ba96
!     if (expr == NULL)
d6ba96
      {
d6ba96
  	/*
d6ba96
  	 * ":let" without "=": list variables
d6ba96
--- 1856,1864 ----
d6ba96
  	return;
d6ba96
      if (argend > arg && argend[-1] == '.')  /* for var.='str' */
d6ba96
  	--argend;
d6ba96
!     expr = skipwhite(argend);
d6ba96
!     if (*expr != '=' && !(vim_strchr((char_u *)"+-.", *expr) != NULL
d6ba96
! 			  && expr[1] == '='))
d6ba96
      {
d6ba96
  	/*
d6ba96
  	 * ":let" without "=": list variables
d6ba96
***************
d6ba96
*** 1886,1897 ****
d6ba96
      {
d6ba96
  	op[0] = '=';
d6ba96
  	op[1] = NUL;
d6ba96
! 	if (expr > argend)
d6ba96
  	{
d6ba96
! 	    if (vim_strchr((char_u *)"+-.", expr[-1]) != NULL)
d6ba96
! 		op[0] = expr[-1];   /* +=, -= or .= */
d6ba96
  	}
d6ba96
! 	expr = skipwhite(expr + 1);
d6ba96
  
d6ba96
  	if (eap->skip)
d6ba96
  	    ++emsg_skip;
d6ba96
--- 1887,1900 ----
d6ba96
      {
d6ba96
  	op[0] = '=';
d6ba96
  	op[1] = NUL;
d6ba96
! 	if (*expr != '=')
d6ba96
  	{
d6ba96
! 	    if (vim_strchr((char_u *)"+-.", *expr) != NULL)
d6ba96
! 		op[0] = *expr;   /* +=, -= or .= */
d6ba96
! 	    expr = skipwhite(expr + 2);
d6ba96
  	}
d6ba96
! 	else
d6ba96
! 	    expr = skipwhite(expr + 1);
d6ba96
  
d6ba96
  	if (eap->skip)
d6ba96
  	    ++emsg_skip;
d6ba96
*** ../vim-7.4.228/src/testdir/test104.in	2014-02-05 22:25:29.982568243 +0100
d6ba96
--- src/testdir/test104.in	2014-03-30 16:44:39.432561197 +0200
d6ba96
***************
d6ba96
*** 1,4 ****
d6ba96
! Tests for autoload.  vim: set ft=vim ts=8 :
d6ba96
  
d6ba96
  STARTTEST
d6ba96
  :so small.vim
d6ba96
--- 1,4 ----
d6ba96
! Tests for :let.  vim: set ft=vim ts=8 :
d6ba96
  
d6ba96
  STARTTEST
d6ba96
  :so small.vim
d6ba96
***************
d6ba96
*** 10,15 ****
d6ba96
--- 10,29 ----
d6ba96
  :catch
d6ba96
  :  $put ='FAIL: ' . v:exception
d6ba96
  :endtry
d6ba96
+ :let a = 1
d6ba96
+ :let b = 2
d6ba96
+ :for letargs in ['a b', '{0 == 1 ? "a" : "b"}', '{0 == 1 ? "a" : "b"} a', 'a {0 == 1 ? "a" : "b"}']
d6ba96
+ :  try
d6ba96
+ :    redir => messages
d6ba96
+ :    execute 'let' letargs
d6ba96
+ :    redir END
d6ba96
+ :    $put ='OK:'
d6ba96
+ :    $put =split(substitute(messages, '\n', '\0  ', 'g'), '\n')
d6ba96
+ :  catch
d6ba96
+ :    $put ='FAIL: ' . v:exception
d6ba96
+ :    redir END
d6ba96
+ :  endtry
d6ba96
+ :endfor
d6ba96
  :/^Results/,$wq! test.out
d6ba96
  ENDTEST
d6ba96
  
d6ba96
*** ../vim-7.4.228/src/testdir/test104.ok	2014-02-05 22:25:29.982568243 +0100
d6ba96
--- src/testdir/test104.ok	2014-03-30 16:44:39.432561197 +0200
d6ba96
***************
d6ba96
*** 1,2 ****
d6ba96
--- 1,13 ----
d6ba96
  Results of test104:
d6ba96
  OK: function('tr')
d6ba96
+ OK:
d6ba96
+   a                     #1
d6ba96
+   b                     #2
d6ba96
+ OK:
d6ba96
+   b                     #2
d6ba96
+ OK:
d6ba96
+   b                     #2
d6ba96
+   a                     #1
d6ba96
+ OK:
d6ba96
+   a                     #1
d6ba96
+   b                     #2
d6ba96
*** ../vim-7.4.228/src/version.c	2014-03-30 16:11:37.180530823 +0200
d6ba96
--- src/version.c	2014-03-30 16:46:39.660563039 +0200
d6ba96
***************
d6ba96
*** 736,737 ****
d6ba96
--- 736,739 ----
d6ba96
  {   /* Add new patch number below this line */
d6ba96
+ /**/
d6ba96
+     229,
d6ba96
  /**/
d6ba96
d6ba96
-- 
d6ba96
You have heard the saying that if you put a thousand monkeys in a room with a
d6ba96
thousand typewriters and waited long enough, eventually you would have a room
d6ba96
full of dead monkeys.
d6ba96
				(Scott Adams - The Dilbert principle)
d6ba96
d6ba96
 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
d6ba96
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
d6ba96
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
d6ba96
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///