|
 |
f731ee |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
f731ee |
From: Peter Jones <pjones@redhat.com>
|
|
|
f731ee |
Date: Wed, 24 May 2017 15:58:18 -0400
|
|
|
f731ee |
Subject: [PATCH] Clean up some errors in the linuxefi loader
|
|
|
f731ee |
|
|
|
f731ee |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
f731ee |
---
|
|
|
f731ee |
grub-core/loader/i386/efi/linux.c | 16 ++++++++--------
|
|
|
f731ee |
1 file changed, 8 insertions(+), 8 deletions(-)
|
|
|
f731ee |
|
|
|
f731ee |
diff --git a/grub-core/loader/i386/efi/linux.c b/grub-core/loader/i386/efi/linux.c
|
|
|
f731ee |
index c123afad19c..7166ec17f8f 100644
|
|
|
f731ee |
--- a/grub-core/loader/i386/efi/linux.c
|
|
|
f731ee |
+++ b/grub-core/loader/i386/efi/linux.c
|
|
|
f731ee |
@@ -161,8 +161,8 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
|
|
|
f731ee |
int argc, char *argv[])
|
|
|
f731ee |
{
|
|
|
f731ee |
grub_file_t file = 0;
|
|
|
f731ee |
- struct linux_kernel_header *lh;
|
|
|
f731ee |
- grub_ssize_t len, start, filelen;
|
|
|
f731ee |
+ struct linux_kernel_header *lh = NULL;
|
|
|
f731ee |
+ grub_ssize_t start, filelen;
|
|
|
f731ee |
void *kernel = NULL;
|
|
|
f731ee |
int setup_header_end_offset;
|
|
|
f731ee |
int rc;
|
|
|
f731ee |
@@ -212,18 +212,19 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
|
|
|
f731ee |
goto fail;
|
|
|
f731ee |
}
|
|
|
f731ee |
|
|
|
f731ee |
- grub_dprintf ("linuxefi", "params = %p\n", (unsigned long) params);
|
|
|
f731ee |
+ grub_dprintf ("linuxefi", "params = %p\n", params);
|
|
|
f731ee |
|
|
|
f731ee |
grub_memset (params, 0, sizeof(*params));
|
|
|
f731ee |
|
|
|
f731ee |
setup_header_end_offset = *((grub_uint8_t *)kernel + 0x201);
|
|
|
f731ee |
grub_dprintf ("linuxefi", "copying %lu bytes from %p to %p\n",
|
|
|
f731ee |
- MIN(0x202+setup_header_end_offset,sizeof (*params)) - 0x1f1,
|
|
|
f731ee |
+ MIN((grub_size_t)0x202+setup_header_end_offset,
|
|
|
f731ee |
+ sizeof (*params)) - 0x1f1,
|
|
|
f731ee |
(grub_uint8_t *)kernel + 0x1f1,
|
|
|
f731ee |
(grub_uint8_t *)params + 0x1f1);
|
|
|
f731ee |
grub_memcpy ((grub_uint8_t *)params + 0x1f1,
|
|
|
f731ee |
(grub_uint8_t *)kernel + 0x1f1,
|
|
|
f731ee |
- MIN(0x202+setup_header_end_offset,sizeof (*params)) - 0x1f1);
|
|
|
f731ee |
+ MIN((grub_size_t)0x202+setup_header_end_offset,sizeof (*params)) - 0x1f1);
|
|
|
f731ee |
lh = (struct linux_kernel_header *)params;
|
|
|
f731ee |
grub_dprintf ("linuxefi", "lh is at %p\n", lh);
|
|
|
f731ee |
grub_dprintf ("linuxefi", "checking lh->boot_flag\n");
|
|
|
f731ee |
@@ -254,7 +255,7 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
|
|
|
f731ee |
goto fail;
|
|
|
f731ee |
}
|
|
|
f731ee |
|
|
|
f731ee |
-#ifdef defined(__x86_64__) || defined(__aarch64__)
|
|
|
f731ee |
+#if defined(__x86_64__) || defined(__aarch64__)
|
|
|
f731ee |
grub_dprintf ("linuxefi", "checking lh->xloadflags\n");
|
|
|
f731ee |
if (!(lh->xloadflags & LINUX_XLF_KERNEL_64))
|
|
|
f731ee |
{
|
|
|
f731ee |
@@ -298,7 +299,6 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
|
|
|
f731ee |
handover_offset = lh->handover_offset;
|
|
|
f731ee |
|
|
|
f731ee |
start = (lh->setup_sects + 1) * 512;
|
|
|
f731ee |
- len = grub_file_size(file) - start;
|
|
|
f731ee |
|
|
|
f731ee |
kernel_mem = grub_efi_allocate_pages(lh->pref_address,
|
|
|
f731ee |
BYTES_TO_PAGES(lh->init_size));
|
|
|
f731ee |
@@ -344,7 +344,7 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
|
|
|
f731ee |
loaded = 0;
|
|
|
f731ee |
}
|
|
|
f731ee |
|
|
|
f731ee |
- if (linux_cmdline && !loaded)
|
|
|
f731ee |
+ if (linux_cmdline && lh && !loaded)
|
|
|
f731ee |
grub_efi_free_pages ((grub_efi_physical_address_t)(grub_addr_t)
|
|
|
f731ee |
linux_cmdline,
|
|
|
f731ee |
BYTES_TO_PAGES(lh->cmdline_size + 1));
|