Blame SOURCES/dhcp-4.2.5-PPP.patch

fad460
diff -up dhcp-4.2.4b1/client/dhc6.c.PPP dhcp-4.2.4b1/client/dhc6.c
fad460
--- dhcp-4.2.4b1/client/dhc6.c.PPP	2012-04-16 17:37:23.243618764 +0200
fad460
+++ dhcp-4.2.4b1/client/dhc6.c	2012-04-16 17:37:23.252618638 +0200
fad460
@@ -133,7 +133,7 @@ extern int stateless;
fad460
  * is not how it is intended.  Upcoming rearchitecting the client should
fad460
  * address this "one daemon model."
fad460
  */
fad460
-void
fad460
+isc_result_t
fad460
 form_duid(struct data_string *duid, const char *file, int line)
fad460
 {
fad460
 	struct interface_info *ip;
fad460
@@ -145,6 +145,15 @@ form_duid(struct data_string *duid, cons
fad460
 	if (ip == NULL)
fad460
 		log_fatal("Impossible condition at %s:%d.", MDL);
fad460
 
fad460
+	while (ip && ip->hw_address.hbuf[0] == HTYPE_RESERVED) {
fad460
+		/* Try the other interfaces */
fad460
+		log_debug("Cannot form default DUID from interface %s.", ip->name);
fad460
+		ip = ip->next;
fad460
+	}
fad460
+	if (ip == NULL) {
fad460
+		return ISC_R_UNEXPECTED;
fad460
+	}
fad460
+
fad460
 	if ((ip->hw_address.hlen == 0) ||
fad460
 	    (ip->hw_address.hlen > sizeof(ip->hw_address.hbuf)))
fad460
 		log_fatal("Impossible hardware address length at %s:%d.", MDL);
fad460
@@ -180,6 +189,8 @@ form_duid(struct data_string *duid, cons
fad460
 		memcpy(duid->buffer->data + 4, ip->hw_address.hbuf + 1,
fad460
 		       ip->hw_address.hlen - 1);
fad460
 	}
fad460
+
fad460
+	return ISC_R_SUCCESS;
fad460
 }
fad460
 
fad460
 /*
fad460
@@ -5130,7 +5141,8 @@ make_client6_options(struct client_state
fad460
 	 */
fad460
 	if ((oc = lookup_option(&dhcpv6_universe, *op,
fad460
 				D6O_CLIENTID)) == NULL) {
fad460
-		if (!option_cache(&oc, &default_duid, NULL, clientid_option,
fad460
+		if (default_duid.len == 0 ||
fad460
+		    !option_cache(&oc, &default_duid, NULL, clientid_option,
fad460
 				  MDL))
fad460
 			log_fatal("Failure assembling a DUID.");
fad460
 
fad460
diff -up dhcp-4.2.4b1/client/dhclient.c.PPP dhcp-4.2.4b1/client/dhclient.c
fad460
--- dhcp-4.2.4b1/client/dhclient.c.PPP	2012-04-16 17:37:23.214619170 +0200
fad460
+++ dhcp-4.2.4b1/client/dhclient.c	2012-04-16 17:37:23.254618610 +0200
fad460
@@ -919,8 +919,8 @@ main(int argc, char **argv) {
fad460
 			if (default_duid.buffer != NULL)
fad460
 				data_string_forget(&default_duid, MDL);
fad460
 
fad460
-			form_duid(&default_duid, MDL);
fad460
-			write_duid(&default_duid);
fad460
+			if (form_duid(&default_duid, MDL) == ISC_R_SUCCESS)
fad460
+				write_duid(&default_duid);
fad460
 		}
fad460
 
fad460
 		for (ip = interfaces ; ip != NULL ; ip = ip->next) {
fad460
diff -up dhcp-4.2.4b1/common/bpf.c.PPP dhcp-4.2.4b1/common/bpf.c
fad460
--- dhcp-4.2.4b1/common/bpf.c.PPP	2012-04-16 17:37:23.175619716 +0200
fad460
+++ dhcp-4.2.4b1/common/bpf.c	2012-04-16 17:37:23.255618596 +0200
fad460
@@ -599,6 +599,22 @@ get_hw_addr(const char *name, struct har
fad460
                         memcpy(&hw->hbuf[1], LLADDR(sa), sa->sdl_alen);
fad460
                         break;
fad460
 #endif /* IFT_FDDI */
fad460
+#if defined(IFT_PPP)
fad460
+                case IFT_PPP:
fad460
+                        if (local_family != AF_INET6)
fad460
+                             log_fatal("Unsupported device type %d for \"%s\"",
fad460
+                                        sa->sdl_type, name);
fad460
+                        hw->hlen = 0;
fad460
+                        hw->hbuf[0] = HTYPE_RESERVED;
fad460
+                        /* 0xdeadbeef should never occur on the wire,
fad460
+                         *  and is a signature that something went wrong.
fad460
+                         */
fad460
+                        hw->hbuf[1] = 0xde;
fad460
+                        hw->hbuf[2] = 0xad;
fad460
+                        hw->hbuf[3] = 0xbe;
fad460
+                        hw->hbuf[4] = 0xef;
fad460
+                        break;
fad460
+#endif
fad460
                 default:
fad460
                         log_fatal("Unsupported device type %d for \"%s\"",
fad460
                                   sa->sdl_type, name);
fad460
diff -up dhcp-4.2.4b1/common/lpf.c.PPP dhcp-4.2.4b1/common/lpf.c
fad460
--- dhcp-4.2.4b1/common/lpf.c.PPP	2012-04-16 17:37:23.155619996 +0200
fad460
+++ dhcp-4.2.4b1/common/lpf.c	2012-04-16 17:37:23.256618582 +0200
fad460
@@ -503,6 +503,22 @@ get_hw_addr(const char *name, struct har
fad460
 			hw->hbuf[0] = HTYPE_FDDI;
fad460
 			memcpy(&hw->hbuf[1], sa->sa_data, 6);
fad460
 			break;
fad460
+#if defined(ARPHRD_PPP)
fad460
+		case ARPHRD_PPP:
fad460
+			if (local_family != AF_INET6)
fad460
+				log_fatal("Unsupported device type %d for \"%s\"",
fad460
+				           sa->sa_family, name);
fad460
+			hw->hlen = 0;
fad460
+			hw->hbuf[0] = HTYPE_RESERVED;
fad460
+			/* 0xdeadbeef should never occur on the wire,
fad460
+			 * and is a signature that something went wrong.
fad460
+			 */
fad460
+			hw->hbuf[1] = 0xde;
fad460
+			hw->hbuf[2] = 0xad;
fad460
+			hw->hbuf[3] = 0xbe;
fad460
+			hw->hbuf[4] = 0xef;
fad460
+			break;
fad460
+#endif
fad460
 		default:
fad460
 			log_fatal("Unsupported device type %ld for \"%s\"",
fad460
 				  (long int)sa->sa_family, name);
fad460
diff -up dhcp-4.2.4b1/includes/dhcpd.h.PPP dhcp-4.2.4b1/includes/dhcpd.h
fad460
--- dhcp-4.2.4b1/includes/dhcpd.h.PPP	2012-04-16 17:37:23.239618820 +0200
fad460
+++ dhcp-4.2.4b1/includes/dhcpd.h	2012-04-16 17:37:23.257618568 +0200
fad460
@@ -2760,7 +2760,7 @@ void dhcpv4_client_assignments(void);
fad460
 void dhcpv6_client_assignments(void);
fad460
 
fad460
 /* dhc6.c */
fad460
-void form_duid(struct data_string *duid, const char *file, int line);
fad460
+isc_result_t form_duid(struct data_string *duid, const char *file, int line);
fad460
 void dhc6_lease_destroy(struct dhc6_lease **src, const char *file, int line);
fad460
 void start_init6(struct client_state *client);
fad460
 void start_info_request6(struct client_state *client);
fad460
diff -up dhcp-4.2.4b1/includes/dhcp.h.PPP dhcp-4.2.4b1/includes/dhcp.h
fad460
--- dhcp-4.2.4b1/includes/dhcp.h.PPP	2012-04-16 17:37:23.000000000 +0200
fad460
+++ dhcp-4.2.4b1/includes/dhcp.h	2012-04-16 17:38:34.675618138 +0200
fad460
@@ -85,6 +85,8 @@ struct dhcp_packet {
fad460
 					 * is no standard for this so we
fad460
 					 * just steal a type            */
fad460
 
fad460
+#define HTYPE_RESERVED	0		/* RFC 5494 */
fad460
+
fad460
 /* Magic cookie validating dhcp options field (and bootp vendor
fad460
    extensions field). */
fad460
 #define DHCP_OPTIONS_COOKIE	"\143\202\123\143"
fad460
diff -up dhcp-4.2.4b1/server/dhcpv6.c.PPP dhcp-4.2.4b1/server/dhcpv6.c
fad460
--- dhcp-4.2.4b1/server/dhcpv6.c.PPP	2012-04-16 17:37:23.218619114 +0200
fad460
+++ dhcp-4.2.4b1/server/dhcpv6.c	2012-04-16 17:37:23.260618526 +0200
fad460
@@ -300,6 +300,9 @@ generate_new_server_duid(void) {
fad460
 		if (p->hw_address.hlen > 0) {
fad460
 			break;
fad460
 		}
fad460
+		if (p->next == NULL && p->hw_address.hbuf[0] == HTYPE_RESERVED) {
fad460
+			log_error("Can not generate DUID from interfaces which do not have hardware addresses, please configure server-duid!");
fad460
+		}
fad460
 	}
fad460
 	if (p == NULL) {
fad460
 		return ISC_R_UNEXPECTED;