|
 |
304803 |
autofs-5.1.4 - fix fd leak in rpc_do_create_client()
|
|
|
304803 |
|
|
|
304803 |
From: Ian Kent <raven@themaw.net>
|
|
|
304803 |
|
|
|
304803 |
Commit 94f87e203a (fix create_client() RPC client handling) fixed
|
|
|
304803 |
possible use of an invalid RPC client handle but the change neglected
|
|
|
304803 |
to account of a check in rpc_do_create_client() that would open a new
|
|
|
304803 |
file descriptor without checking if the passed if descriptor was
|
|
|
304803 |
already opened.
|
|
|
304803 |
|
|
|
304803 |
Signed-off-by: Ian Kent <raven@themaw.net>
|
|
|
304803 |
---
|
|
|
304803 |
CHANGELOG | 1 +
|
|
|
304803 |
lib/rpc_subs.c | 4 ++--
|
|
|
304803 |
2 files changed, 3 insertions(+), 2 deletions(-)
|
|
|
304803 |
|
|
|
304803 |
--- autofs-5.0.7.orig/CHANGELOG
|
|
|
304803 |
+++ autofs-5.0.7/CHANGELOG
|
|
|
304803 |
@@ -297,6 +297,7 @@
|
|
|
304803 |
- fix error return in do_nfs_mount().
|
|
|
304803 |
- fix create_client() RPC client handling.
|
|
|
304803 |
- dont allow trailing slash in master map mount points.
|
|
|
304803 |
+- fix fd leak in rpc_do_create_client().
|
|
|
304803 |
|
|
|
304803 |
25/07/2012 autofs-5.0.7
|
|
|
304803 |
=======================
|
|
|
304803 |
--- autofs-5.0.7.orig/lib/rpc_subs.c
|
|
|
304803 |
+++ autofs-5.0.7/lib/rpc_subs.c
|
|
|
304803 |
@@ -192,7 +192,7 @@ static int rpc_do_create_client(struct s
|
|
|
304803 |
in4_laddr.sin_addr.s_addr = htonl(INADDR_ANY);
|
|
|
304803 |
slen = sizeof(struct sockaddr_in);
|
|
|
304803 |
|
|
|
304803 |
- if (!info->client) {
|
|
|
304803 |
+ if (!info->client && *fd == RPC_ANYSOCK) {
|
|
|
304803 |
struct sockaddr *laddr;
|
|
|
304803 |
|
|
|
304803 |
*fd = open_sock(addr->sa_family, type, proto);
|
|
|
304803 |
@@ -304,7 +304,7 @@ static int rpc_do_create_client(struct s
|
|
|
304803 |
* it would bind to a reserved port, which has been shown to
|
|
|
304803 |
* exhaust the reserved port range in some situations.
|
|
|
304803 |
*/
|
|
|
304803 |
- if (!info->client) {
|
|
|
304803 |
+ if (!info->client && *fd == RPC_ANYSOCK) {
|
|
|
304803 |
*fd = open_sock(addr->sa_family, type, proto);
|
|
|
304803 |
if (*fd < 0) {
|
|
|
304803 |
ret = -errno;
|